Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip i18n-ignore-rewrite-source irrelevant tests with turbopack #57289

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 23, 2023

These tests are expecting files to be written but this isn't the case with turbopack for client files.

@ijjk
Copy link
Member Author

ijjk commented Oct 23, 2023

Failing test suites

Commit: 8d82b77

pnpm test-dev test/development/basic/gssp-ssr-change-reloading/test/index.test.ts

  • GS(S)P Server-Side Change Reloading > should not reload page when client-side is changed too GSP
Expand output

● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSP

TIMED OUT: change me

changed

undefined

  626 |
  627 |   if (hardError) {
> 628 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  629 |   }
  630 |   return false
  631 | }

  at check (lib/next-test-utils.ts:628:11)
  at Object.<anonymous> (development/basic/gssp-ssr-change-reloading/test/index.test.ts:53:5)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member Author

ijjk commented Oct 23, 2023

Stats from current PR

Default Build
General
vercel/next.js canary ijjk/next.js tests/i18n-ignore-rewrite Change
buildDuration 10.7s 10.8s N/A
buildDurationCached 6.1s 6.5s ⚠️ +384ms
nodeModulesSize 178 MB 178 MB
nextStartRea..uration (ms) 433ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js tests/i18n-ignore-rewrite Change
199-HASH.js gzip 27.9 kB 27.9 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tests/i18n-ignore-rewrite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js tests/i18n-ignore-rewrite Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js tests/i18n-ignore-rewrite Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tests/i18n-ignore-rewrite Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 523 B 522 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js tests/i18n-ignore-rewrite Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 158 kB 158 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js tests/i18n-ignore-rewrite Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 8d82b77

@ijjk ijjk merged commit 1275cff into vercel:canary Oct 23, 2023
@ijjk ijjk deleted the tests/i18n-ignore-rewrite branch October 23, 2023 21:13
ijjk added a commit that referenced this pull request Oct 23, 2023
@github-actions github-actions bot added the locked label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants