Fix app ISR error handling

[ijjk]

This ensures when an error occurs during a revalidate in app router that properly throw the error fully and don't store the error page in the cache which matches the expected behavior for full route ISR as errors are not meant to update the cache so that the last successful cache entry can continue being served.

Fix was tested against the provided reproduction here https://app-dir-example-ghl01cxtn-basement.vercel.app/

Fixes: #53195

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/app-revalidate-error-handling	Change
buildDuration	11.9s	10.4s	N/A
buildDurationCached	5.9s	6.2s	⚠️ +313ms
nodeModulesSize	175 MB	175 MB	⚠️ +5.6 kB
nextStartRea..uration (ms)	436ms	400ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	ijjk/next.js fix/app-revalidate-error-handling	Change
199-HASH.js gzip	32.2 kB	32.3 kB	N/A
3f784ff6-HASH.js gzip	53.2 kB	53.2 kB	N/A
99.HASH.js gzip	182 B	182 B	✓
framework-HASH.js gzip	45.5 kB	45.5 kB	✓
main-app-HASH.js gzip	253 B	252 B	N/A
main-HASH.js gzip	35.3 kB	35.4 kB	N/A
webpack-HASH.js gzip	1.75 kB	1.75 kB	N/A
Overall change	45.7 kB	45.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/app-revalidate-error-handling	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/app-revalidate-error-handling	Change
_app-HASH.js gzip	206 B	205 B	N/A
_error-HASH.js gzip	182 B	180 B	N/A
amp-HASH.js gzip	506 B	505 B	N/A
css-HASH.js gzip	322 B	323 B	N/A
dynamic-HASH.js gzip	2.59 kB	2.59 kB	✓
edge-ssr-HASH.js gzip	260 B	259 B	N/A
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.38 kB	4.38 kB	N/A
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	316 B	318 B	N/A
script-HASH.js gzip	385 B	384 B	N/A
withRouter-HASH.js gzip	319 B	319 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.99 kB	3.99 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/app-revalidate-error-handling	Change
_buildManifest.js gzip	484 B	482 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/app-revalidate-error-handling	Change
index.html gzip	528 B	531 B	N/A
link.html gzip	542 B	542 B	✓
withRouter.html gzip	524 B	524 B	✓
Overall change	1.07 kB	1.07 kB	✓

Edge SSR bundle Size Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/app-revalidate-error-handling	Change
edge-ssr.js gzip	95.9 kB	96 kB	N/A
page.js gzip	139 kB	139 kB	⚠️ +108 B
Overall change	139 kB	139 kB	⚠️ +108 B

Middleware size

	vercel/next.js canary	ijjk/next.js fix/app-revalidate-error-handling	Change
middleware-b..fest.js gzip	625 B	624 B	N/A
middleware-r..fest.js gzip	150 B	151 B	N/A
middleware.js gzip	25.8 kB	25.8 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	1.92 kB	1.92 kB	✓

Diff details

Diff for page.js

Diff too large to display

Diff for 199-HASH.js

Diff too large to display

Commit: 409c2f0

[ijjk]

Tests Passed