turbopack: Implement Server Actions from Client Components #57391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
ijjk
added
Turbopack
This reverts commit bfdb349.
jridgewell
force-pushed
the
jrl-client-server-actions
branch
from
5410c4a to
84251f1
Compare
sokra
previously approved these changes
Oct 25, 2023
| async fn get_actions(module: Vc<Box<dyn Module>>) -> Result<Vc<ModuleActionMap>> { | ||
| async fn get_actions( | ||
| rsc_entry: Vc<Box<dyn Module>>, | ||
| server_reference_modules: Vc<Vec<Vc<Box<dyn Module>>>>, |
| parent: Vc<Box<dyn Module>>, | ||
| ) -> Result<impl Iterator<Item = Vc<Box<dyn Module>>> + Send> { | ||
| primary_referenced_modules(parent) | ||
| (layer, module): (ActionLayer, Vc<Box<dyn Module>>), |
There was a problem hiding this comment.
This is invoked by NonDeterministic::visit's fn impl, which only accepts a single arg.
Stats from current PRDefault BuildGeneral Overall increase
|
| vercel/next.js canary | vercel/next.js jrl-client-server-actions | Change | |
|---|---|---|---|
| buildDuration | 10.1s | 10s | N/A |
| buildDurationCached | 6s | 6s | N/A |
| nodeModulesSize | 175 MB | 175 MB | |
| nextStartRea..uration (ms) | 399ms | 398ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js jrl-client-server-actions | Change | |
|---|---|---|---|
| 199-HASH.js gzip | 32.3 kB | 32.4 kB | N/A |
| 3f784ff6-HASH.js gzip | 53.2 kB | 53.2 kB | N/A |
| 99.HASH.js gzip | 182 B | 182 B | ✓ |
| framework-HASH.js gzip | 45.5 kB | 45.5 kB | ✓ |
| main-app-HASH.js gzip | 254 B | 252 B | N/A |
| main-HASH.js gzip | 35.3 kB | 35.4 kB | N/A |
| webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
| Overall change | 45.7 kB | 45.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js jrl-client-server-actions | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js jrl-client-server-actions | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 206 B | 205 B | N/A |
| _error-HASH.js gzip | 182 B | 180 B | N/A |
| amp-HASH.js gzip | 506 B | 505 B | N/A |
| css-HASH.js gzip | 322 B | 323 B | N/A |
| dynamic-HASH.js gzip | 2.59 kB | 2.59 kB | ✓ |
| edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 369 B | 369 B | ✓ |
| image-HASH.js gzip | 4.38 kB | 4.38 kB | N/A |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 316 B | 318 B | N/A |
| script-HASH.js gzip | 385 B | 384 B | N/A |
| withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 3.99 kB | 3.99 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js jrl-client-server-actions | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 484 B | 482 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js jrl-client-server-actions | Change | |
|---|---|---|---|
| index.html gzip | 528 B | 530 B | N/A |
| link.html gzip | 542 B | 543 B | N/A |
| withRouter.html gzip | 524 B | 524 B | ✓ |
| Overall change | 524 B | 524 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js jrl-client-server-actions | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 96 kB | 96 kB | N/A |
| page.js gzip | 139 kB | 140 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js jrl-client-server-actions | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 622 B | 625 B | N/A |
| middleware-r..fest.js gzip | 150 B | 151 B | N/A |
| middleware.js gzip | 25.8 kB | 25.8 kB | N/A |
| edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
| Overall change | 1.92 kB | 1.92 kB | ✓ |
sokra
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This completes Turbopack's Server Actions implementation!
It also cleans up several things:
server_actionsconfiguration, it's enabled by default now.Why?
How?
It crawls the client layer modules for additional Server Actions imports, and adds them to our generated
actions.jsentry point.Closes NEXT-
Fixes #
Closes WEB-1854