-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codemods: migrate viewport related metadata export to viewport export #57436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
Tests Passed |
ztanner
previously approved these changes
Oct 25, 2023
huozhi
commented
Oct 25, 2023
docs/02-app/01-building-your-application/09-upgrading/01-codemods.mdx
Outdated
Show resolved
Hide resolved
254c3f4
to
0255fbf
Compare
ztanner
approved these changes
Oct 25, 2023
shuding
approved these changes
Oct 25, 2023
Merged
@leerob Please update this blog post with instructions on how to do the update, including running these codemods. I can imagine npm script which will do the update with running codemods for the new version out of the box, what do you think? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the codemods transforming certain fields from
metadata
export toviewport
export, will still preserve rest metadata export properties. We don't covergenerateMetadata
togenerateViewport
as there might be more complex logic inside the function which is hard to apply the codemods rules.TLDR: Codemods for #57302