Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out CSS files from middleware files and client reference chunks #57482

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Filter out CSS files from middleware files and client reference chunks #57482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/next-swc/crates/next-api/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,7 @@ impl AppEndpoint {
async move {
Ok(node_root_value
.get_path_to(&*file.ident().path().await?)
.filter(|path| path.ends_with(".js"))
.map(|path| path.to_string()))
}
}
Expand All @@ -882,6 +883,7 @@ impl AppEndpoint {
async move {
Ok(node_root_value
.get_path_to(&*file.ident().path().await?)
.filter(|path| path.ends_with(".js"))
.map(|path| path.to_string()))
}
})
Expand Down
3 changes: 3 additions & 0 deletions packages/next-swc/crates/next-core/src/next_manifests/client_reference_manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ impl ClientReferenceManifest {
.iter()
.filter_map(|chunk_path| client_relative_path.get_path_to(chunk_path))
.map(ToString::to_string)
// It's possible that a chunk also emits CSS files, that will
// be handled separatedly.
.filter(|path| path.ends_with(".js"))
.collect::<Vec<_>>();

let ssr_chunks_paths = ssr_chunks
Expand Down