-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next-swc): Provide tokio context required for WASM plugins #62441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for middleware.jsDiff too large to display |
sokra
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
napi provides a tokio runtime. Could we use that instead of creating a new one?
@sokra We need to move operations like cloning the options slice to the main JS thread if we want to do so. ![]()
|
Fixed. |
Tests Passed |
sokra
approved these changes
Feb 27, 2024
ForsakenHarmony
approved these changes
Feb 27, 2024
1 task
sokra
added a commit
that referenced
this pull request
Mar 13, 2024
### What? - Update `swc_core` to fix performance regression caused by the creation of the `tokio` runtime. This PR practically reverts #62441. - Apply various minifier bug fixes. - swc-project/swc#8730 - swc-project/swc#8733 - swc-project/swc#8725 - swc-project/swc#8726 - swc-project/swc#8727 - Apply swc-project/plugins#271 (Closes PACK-2714) ### Why? Someone reported a performance regression. See swc-project/swc#8708 ### How? Closes PACK-2693 --------- Co-authored-by: Tobias Koppers <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Run transforms with the tokio context so Wasmer works properly.
Why?
To allow invoking Wasm plugins.
wasmer
had a breaking change.How?
Closes PACK-2587
Closes #62081