Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to Rust 1.85.0 #10024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update to Rust 1.85.0 #10024

wants to merge 1 commit into from

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Feb 22, 2025 •
edited
Loading

Description

Testing Instructions

@ognevny ognevny requested a review from a team as a code owner February 22, 2025 09:35
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Feb 22, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 4:10pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 4:10pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 4:10pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 4:10pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 4:10pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 4:10pm

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2025

@ognevny is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ognevny
Copy link
Contributor Author

ognevny commented Feb 22, 2025

not migrating to edition 2024 because it requires lots of code/formatting changes

@ognevny ognevny changed the title chore: Update to Rust 1.85.0 chore: update to Rust 1.85.0 Feb 22, 2025
@ognevny
Copy link
Contributor Author

ognevny commented Feb 23, 2025

Windows test failure seems unrelated

thread 'globwatcher::test::watch_single_file' panicked at crates\turborepo-lib\src\globwatcher\mod.rs:684:9:
assertion `left == right` failed: expected one of the globs to have changed
  left: {}
 right: {"my-pkg/.next/next-file"}

NicholasLYang
NicholasLYang approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@NicholasLYang NicholasLYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@chris-olszewski chris-olszewski self-requested a review February 25, 2025 15:40
chris-olszewski
chris-olszewski requested changes Feb 25, 2025
View reviewed changes
crates/turborepo-globwatch/src/lib.rs
@@ -214,7 +214,7 @@ impl GlobWatcher {
// requester. flushes should not be considered as events.
for flush_id in e
.paths
.extract_if(|p| p.starts_with(flush_dir.as_path()))
.extract_if(.., |p| p.starts_with(flush_dir.as_path()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how or why this is only affecting Windows, but this is on the codepath for the failing Windows test. I haven't seen the test be flakey before so I think the changes to this function might actually have a regression (or we were misusing it somehow).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

briefly looking at upstream PR didn't find anything that could regress the function... maybe to try fill an issue upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski requested changes

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ognevny @chris-olszewski @NicholasLYang