-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tools dependencies and improve their readmes #350
Conversation
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
=======================================
Coverage 68.14% 68.14%
=======================================
Files 29 29
Lines 1400 1400
Branches 204 203 -1
=======================================
Hits 954 954
Misses 406 406
Partials 40 40
Continue to review full report at Codecov.
|
ed11de2
to
75d9d79
Compare
@@ -51,8 +51,7 @@ | |||
}, | |||
"lint-staged": { | |||
"**/*.{js,ts}": [ | |||
"eslint --fix", | |||
"git add" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we remove "git add"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main breaking change lint-staged
added in v10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , check my comments before merge 💯
75d9d79
to
55d53e9
Compare
BREAKING CHANGE New minimum Node version supported is 10.x. Also, new Prettier minimum version is 2.0.2
55d53e9
to
3882a2d
Compare
Type: chore
Scope: tools
The following has been addressed in the PR:
Description: Update monorepo and tools packages dependencies, apply Prettier v2 changes and add more detail to README file in each tools project