Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate build-from-source* features to sdl3-image-sys crate #117

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

PeakKS
Copy link
Contributor

@PeakKS PeakKS commented Feb 16, 2025

Also build sdl3-image-sys from source when using build-from-source feature.

@revmischa
Copy link
Collaborator

Does it mean you always get sdl3-image-sys even if you're not using it?

@revmischa revmischa requested review from maia-s and Lokathor February 16, 2025 22:33
@PeakKS
Copy link
Contributor Author

PeakKS commented Feb 19, 2025

Does it mean you always get sdl3-image-sys even if you're not using it?

It shouldn't, this just sets the flag if you are both using the image crate and have the build-from-source flag set on the main crate.

@revmischa
Copy link
Collaborator

Cool okay

@revmischa revmischa merged commit da7d480 into vhspace:master Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants