keep AudioSubsystem alive while AudioDevices or AudioStreama are alive
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonilol
commented
Feb 19, 2025
Comment on lines
+670
to
675
| pub fn new(device_id: AudioDeviceID, audio_subsystem: AudioSubsystem) -> Self { | ||
| AudioDevice { | ||
| device_id, | ||
| audio_subsystem, | ||
| } | ||
| } |
There was a problem hiding this comment.
Should this be part of the public API?
|
I will later today check if this actually fixes the problem Edit: it does |
antonilol
commented
Feb 19, 2025
| } | ||
|
|
||
| /// Create an `AudioStream` for this device with the specified spec. | ||
| /// This device will be closed when the stream is dropped. | ||
| /// The device begins paused, so you must call `stream.resume()` to start playback. | ||
| #[doc(alias = "SDL_OpenAudioDeviceStream")] | ||
| #[deprecated = "use `device.open_device_stream(spec)` (where device is an `AudioDevice`) instead"] |
There was a problem hiding this comment.
What should happen with this function? It is almost identical to AudioDevice::open_device_stream (I added this in 57069b2 because it has 2 parameters that are fields of AudioDevice, so it is easier to call with only 1 parameter excluding self).
There was a problem hiding this comment.
After a successful SDL_OpenAudioDeviceStream call SDL will close the device when the stream is closed, so it makes sense to me to take an AudioDevice by value (self parameter there) in Rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking change because some functions allowed creating streams or devices without requiring an
AudioSubsystemfixes #79