Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test coverage and fix subscription-related issues #20

Merged
merged 7 commits into from
Nov 16, 2024

Conversation

vicfergar
Copy link
Owner

@vicfergar vicfergar commented Nov 16, 2024

This PR enhances the test coverage for the subscriptions API and StateChangedEventListener while fixing several critical issues related to event handling and unsubscription logic.

Key changes

Bug Fixes

  • Fixed incorrect message format in unsubscribe_events type
  • Corrected RemoveEventHandlerSubscriptionAsync method to properly handle unregistered handlers
  • Resolved an issue where unsubscribe methods weren't working with multiple subscriptions

Test Coverage Improvements

  • Added comprehensive integration tests for StateChangedEventListener
  • Expanded test coverage for the Subscriptions API
  • Added Connection event integration tests

NOTE: Version bumped from 2.0.1 to 2.0.2 to reflect the bug fixes

Related to #8

@vicfergar vicfergar merged commit b4d575d into main Nov 16, 2024
2 checks passed
@vicfergar vicfergar deleted the chore/add-more-event-tests branch November 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant