Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(captions): write in-band captions from DASH fmp4 segments to the textTrack API #108

Merged
merged 9 commits into from
Jul 16, 2018

Conversation

ldayananda
Copy link
Contributor

@ldayananda ldayananda commented Jun 12, 2018

Description

Depends on videojs/mux.js#197.

This will parse captions from DASH fmp4 segments as each segment request is finished and add them to a corresponding text track(i.e CC1, CC2, CC3, CC4).

Specific Changes proposed

  • requires an update to the mux.js dependency

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@ldayananda ldayananda changed the title [WIP] feat(captions) write in-band captions from DASH fmp4 segments to the textTrack API [WIP] feat(captions): write in-band captions from DASH fmp4 segments to the textTrack API Jun 12, 2018
@ldayananda ldayananda changed the title [WIP] feat(captions): write in-band captions from DASH fmp4 segments to the textTrack API feat(captions): write in-band captions from DASH fmp4 segments to the textTrack API Jun 23, 2018
@ldayananda ldayananda changed the title feat(captions): write in-band captions from DASH fmp4 segments to the textTrack API [WIP] feat(captions): write in-band captions from DASH fmp4 segments to the textTrack API Jun 23, 2018
@ldayananda
Copy link
Contributor Author

ldayananda commented Jun 29, 2018

This has been updated to use a persistent CaptionsParser. It still needs:

  • to be updated to parse the Init segment only when necessary
  • to reset the CaptionsParser and underlying CaptionStream on rendition switches e.c.t
  • unit tests
    - [ ] docs if necessary

@ldayananda ldayananda changed the title [WIP] feat(captions): write in-band captions from DASH fmp4 segments to the textTrack API feat(captions): write in-band captions from DASH fmp4 segments to the textTrack API Jul 5, 2018
@ldayananda
Copy link
Contributor Author

This should be ready for review, the tests fail because the Mux.js PR hasn't been merged and released yet.

I don't think there is anything needed for documentation here?

@forbesjo forbesjo self-assigned this Jul 6, 2018
@forbesjo forbesjo merged commit 7c11911 into videojs:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants