feat: Add useBandwidthFromLocalStorage option #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
gkatsev
reviewed
Oct 26, 2018
src/videojs-http-streaming.js
Outdated
| return null; | ||
| } | ||
|
|
||
| return JSON.parse(storedObject); |
There was a problem hiding this comment.
this probably needs to be try/catched as well as it's possible someone tampered with the value.
src/videojs-http-streaming.js
Outdated
| return null; | ||
| } | ||
|
|
||
| const storedObject = window.localStorage.getItem('videojs-vhs'); |
forbesjo
reviewed
Oct 30, 2018
| @@ -569,6 +632,15 @@ class HlsHandler extends Component { | |||
| this.tech_.one('canplay', | |||
| this.masterPlaylistController_.setupFirstPlay.bind(this.masterPlaylistController_)); | |||
|
|
|||
| this.tech_.on('bandwidthupdate', () => { | |||
| if (this.options_.useBandwidthFromLocalStorage) { | |||
There was a problem hiding this comment.
Might want to add an explicit default value for useBandwidthFromLocalStorage in setOptions_
There was a problem hiding this comment.
Any specific reason to set an explicit default value?
There was a problem hiding this comment.
Just for code as documentation
There was a problem hiding this comment.
It would be nice to see all option defaults live in an object somewhere
forbesjo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces videojs/videojs-contrib-hls#1142
Requirements Checklist