feat: Easier manually playlist switching, add codecs to renditions #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
May 21, 2020
gesinger
previously approved these changes
May 21, 2020
gkatsev
previously approved these changes
May 21, 2020
brandonocasey
force-pushed
the
feat/switch-playlist
branch
from
a67512c to
c776658
Compare
|
Added new tests and fixed tests that were failing after the rebase. |
gkatsev
reviewed
Jun 17, 2020
| @@ -41,20 +49,23 @@ const makeMockPlaylist = function(options) { | |||
| }; | |||
|
|
|||
| const makeMockVhsHandler = function(playlistOptions, handlerOptions) { | |||
| const mcp = { | |||
| const mpc = { | |||
gkatsev
previously approved these changes
Jun 18, 2020
gesinger
reviewed
Jun 18, 2020
| @@ -66,6 +67,10 @@ class Representation { | |||
|
|
|||
| this.bandwidth = playlist.attributes.BANDWIDTH; | |||
|
|
|||
| this.codecs = codecsForPlaylist(mpc.master(), playlist); | |||
|
|
|||
| this.playlist = playlist; | |||
There was a problem hiding this comment.
Do we want to add the whole playlist object to the representation?
There was a problem hiding this comment.
It makes it easier to pass to smoothQualityChange/fastQualityChange
gesinger
reviewed
Jun 18, 2020
gesinger
reviewed
Jun 19, 2020
test/rendition-mixin.test.js
Outdated
Comment on lines
368
to
370
| assert.deepEqual(renditions[0].playlist, vhsHandler.playlists.master.playlists[0], 'rendition 1 has correct codec'); | ||
| assert.deepEqual(renditions[1].playlist, vhsHandler.playlists.master.playlists[1], 'rendition 2 has correct codec'); | ||
| assert.deepEqual(renditions[2].playlist, vhsHandler.playlists.master.playlists[2], 'rendition 3 has no codec'); |
There was a problem hiding this comment.
Suggested change
| assert.deepEqual(renditions[0].playlist, vhsHandler.playlists.master.playlists[0], 'rendition 1 has correct codec'); | |
| assert.deepEqual(renditions[1].playlist, vhsHandler.playlists.master.playlists[1], 'rendition 2 has correct codec'); | |
| assert.deepEqual(renditions[2].playlist, vhsHandler.playlists.master.playlists[2], 'rendition 3 has no codec'); | |
| assert.deepEqual(renditions[0].playlist, vhsHandler.playlists.master.playlists[0], 'rendition 1 has playlist property'); | |
| assert.deepEqual(renditions[1].playlist, vhsHandler.playlists.master.playlists[1], 'rendition 2 has playlist property'); | |
| assert.deepEqual(renditions[2].playlist, vhsHandler.playlists.master.playlists[2], 'rendition 3 has playlist property'); |
gkatsev
approved these changes
Jun 19, 2020
gesinger
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we don't have a great way to manually switch playlists without calling
blacklistCurrentPlaylistand hoping for the best or using the renditions api to exclude all renditions that we don't want. This change allows us to pass a playlist intosmoothQualityChange_andfastQualityChange_so that we can directly change to the playlist we want. It also adds playlist codecs to the rendition API.