fix: support aac data with id3 tags with [email protected] #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Jul 10, 2020
brandonocasey
commented
Jul 10, 2020
| @@ -256,7 +256,7 @@ QUnit.test('aac with id3 will make it to the transmuxer', function(assert) { | |||
| this.options.doneFn = () => { | |||
| assert.deepEqual(this.calls, { | |||
| data: 1, | |||
| trackInfo: 48, | |||
| trackInfo: 1, | |||
There was a problem hiding this comment.
We now only fire trackinfo on the muxer once for audio, rather than every time we fire data or timed-metadata. The partial muxer and video stream already did this.
gesinger
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed while generating some aac content for tests using ffmpeg that we do not support aac content that does not have ID3 tags. This was fixed with [email protected] as mux.js did not recognize aac content without id3 tags as aac content.