Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move tests around #129

Merged
merged 1 commit into from
Jan 21, 2021
Merged

test: move tests around #129

merged 1 commit into from
Jan 21, 2021

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Jan 20, 2021 •
edited
Loading

  1. Moved unit tests that test different parts of the m3u8-parser into different files
  2. Moved .json files to .js files as most of these files use js syntax
  3. Moved all integration fixtures from test/fixtures/m3u8 to test/fixtures/integration as js/m3u8 files are stored there.
  4. Split Parser tests into a few modules, where relevant.
  5. Made Parser tests reuse this.parser
  6. Removed a few manifests that were not being used, and added Error checks to make sure that all manifests are being checked.
  7. Made sure to call this.parser.end() in all parser tests
    No tests were harmed in the making of this pull request.

@brandonocasey brandonocasey force-pushed the test/move-tests-around branch 3 times, most recently from 40bd27c to b78e43a Compare January 20, 2021 20:27
@brandonocasey brandonocasey force-pushed the test/move-tests-around branch from b78e43a to 87235b9 Compare January 20, 2021 20:30
@brandonocasey brandonocasey mentioned this pull request Jan 20, 2021
Merged
@gkatsev
Copy link
Member

gkatsev commented Jan 21, 2021

No tests were harmed in the making of this pull request.

😂

@brandonocasey brandonocasey merged commit e86dcae into main Jan 21, 2021
@brandonocasey brandonocasey deleted the test/move-tests-around branch January 21, 2021 17:01
miadabdi pushed a commit to miadabdi/m3u8-parser that referenced this pull request Jul 21, 2021
@brandonocasey
test: move tests around (videojs#129)
f1374cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @gkatsev