fix(mp4Inspector): read version 1 sidx boxes #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotzte
reviewed
Dec 12, 2019
lib/tools/mp4-inspector.js
Outdated
| } else { | ||
| // read 64 bits | ||
| earliestPresentationTime = view.getUint32(i); | ||
| earliestPresentationTime *= Math.pow(2, 32); |
There was a problem hiding this comment.
Regular integer in javascript is 52 bits. Might want to use BigInt for 64 bits number.
There was a problem hiding this comment.
Unfortunately, browser compatibility doesn't allow us to use BigInt yet. However, since we're working with Uint32 array views, we should still be able to access the full value.
brandonocasey
force-pushed
the
sidx-v1
branch
from
562eacf to
ace31e6
Compare
brandonocasey
force-pushed
the
sidx-v1
branch
from
ace31e6 to
41fea0a
Compare
brandonocasey
approved these changes
Nov 3, 2020
gesinger
approved these changes
Nov 24, 2020
Co-authored-by: Garrett Singer <[email protected]>
brandonocasey
pushed a commit
that referenced
this pull request
Nov 24, 2020
|
accidentally merged this into master. I cherry picked this into main and reverted the change in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #287.