Progress bar can't be filled on 100%

[deser]

At the end of video progress bar not in the end:
https://monosnap.com/image/yhAoC2yYAh7x95ikCMq2xxJokAJptc
https://monosnap.com/image/o9qxlbq17SLWd0O7JMt7hnqlo85CJN

[mmcc]

I'm able to reproduce, but only pretty sporadically. I had just finished up a post saying I couldn't reproduce it, but then I was able to at least 1/3rd of the time. I have a feeling like the only real fix here is to listen for the ended event and force things to 100%. Got a minute for a PR? :)

[deser]

Hi. What is PR? :)

[mmcc]

My apologies for the GitHub lingo :)

PR is a Pull Request, which is a way for you to contribute a change or fix back to the original project. If you're interested in taking a stab at it, the contribution guide gives the basics on how to get started.

[moshoujingli]

It seems that the logic in slider.js (c939ab8) tries to make sure the diamond never touch the left or the right side of the bar box. At the same time, it's also try to make sure the left side of the time indicator bar just in the middle of the diamond, which make the time indicator bar can never reach neither the left nor the right side.So I think maybe it's necessary to decide the appearance of the bar first.

And apologies for my poor English if I haven't described something clearly.

[heff]

We do need to improve that piece of the progress bar. Want to try improving it?=

[moshoujingli]

With pleasure.

[moshoujingli]

Allow me post my view. I think we have to way here.

First is to let the handler to a shape with a side which can cover the bar box side(such as a square, a rounded rect or a circle with shadow). This will cause the change in UI.

Or we can stop to make the right side of the time indicator align to the middle of the diamond, as mentioned above, force the barProcess to 1 while the process is 1.Seems a little tricky, and we also should deal with the handler.

May I have your opinions?

[heff]

Yeah, it seems like the two high-level options are:

1. Use a larger or different shape handle so there's little to no gap when the handle is at an edge
2. Allow the handle edges to go beyond the edges of the progress bar, i.e. the center of the handle is always locked to the mouse, even at 0 and 100%.

In both cases we'd simplify the progress bar itself to not consider the handle in its calculation. At 0% there would be no progress bar visible and at 100% it would fill the space. I definitely like that as a first step towards simplifying this.

[mmcc]

We ripped out the handle adjustment in the progress bar, so this should no longer be an issue.