-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a very basic played() method #2384
Conversation
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: f839478 (Please note that this is a fully automated comment.) |
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: aa77c10 (Please note that this is a fully automated comment.) |
Expose the played attribute on the HTML5 tech. Add a default implementation of played() to the base tech that tracks whether the video has played at all but doesn't provide valid ranges.
The SWF doesn't have an implementation of played so allow Flash to fallback to the base tech implementation.
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 64b785b (Please note that this is a fully automated comment.) |
@pam retry |
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 64b785b (Please note that this is a fully automated comment.) |
Why are we not trying to provide a complete fallback implementation? Time constraint or something else? |
The complete fallback seems like it would be pretty complicated. If viewers start seeking, we have to keep track of all the time ranges that have been viewed and then figure out whether new timeupdate events should be "merged" with an existing range or create a new one. This implementation allows you to find out if the video has been played at all (providing similar functionality to |
Sounds like a good project for a flight. :) I'm fine with merging this in the mean time. We could probably build it without trying to manage seeking events. Just have a threshold of closeness, e.g. 2s. If a timeupdate happens within 2s of an existing timerange, extend it, otherwise start a new one. Then have a followup task that does any merging needed. |
Expose the played attribute on the HTML5 tech. Add a default implementation of played() to the base tech that tracks whether the video has played at all but doesn't provide valid ranges.
For #2323