More Explicitly Deprecate Component.extend #2390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,6 @@ | |||
| var noop = function() {}, clock, oldTextTracks; | |||
|
|
|||
| import videojs from '../../../src/js/video.js'; | |||
There was a problem hiding this comment.
over here since we don't need all of videojs, we can import just the extendsFn itself:
Line 18 in dd9930b
|
Small comment, LGTM otherwise. |
|
I agree with @gkatsev's comment, but otherwise looks good to me. |
|
LGTM |
|
@gkatsev feel free to merge in. |
- Removes a commented-out line and an explanatory comment. - Strips trailing slashes.
misteroneill
force-pushed
the
component-extend
branch
from
bde70f0 to
19d681b
Compare
Merged
|
Thanks @misteroneill! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2383 by making sure
Component.extenduses are removed from the source.Component.extendmethod still exists for backward compatibility.videojs.extends()).