Fixed event bubbling in IE8 #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes videojs#2414 Our fixEvent script makes a copy of the original event, but it was failing to also set cancelBubble = true and returnValue = false on the original event, which is needed to make IE8 work like modern browsers.
heff
force-pushed
the
fix-ie8-bubbling
branch
from
b6f0125 to
4b58fad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2414
Our fixEvent script makes a copy of the original event, but it was failing to also set
cancelBubble = trueandreturnValue = falseon the original event, which is needed to make IE8 work like modern browsers.