Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Spatial Navigation guide #190

Merged
merged 10 commits into from
Jul 25, 2024
Merged

docs: Add Spatial Navigation guide #190

merged 10 commits into from
Jul 25, 2024

Conversation

bzizmo
Copy link
Contributor

@bzizmo bzizmo commented Mar 14, 2024

No description provided.

@bzizmo bzizmo marked this pull request as ready for review April 18, 2024 07:02
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor inline suggestions. The player options should be included in options.mdx too.

* `stop()` - Stops the Spatial Navigation by removing the keydown event listener from the player and updating the internal state.
* `pause()` - Temporarily disables the Spatial Navigation functionality without removing the event listeners.
* `resume()` - Re-enables the Spatial Navigation functionality after it has been paused.
* `updateFocusableComponents()` - Updates and retrieves the list of focusable components within the player.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need to be updated according to videojs/video.js#8717

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieloppenlander
Copy link

Would be great to get this merged, I was trying to implement this, and had to really dig to find the docs hidden in this PR.

@mister-ben mister-ben merged commit 6a9dbb6 into videojs:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants