Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases for single color names (ie red) #109

Open
vilmibm opened this issue Jul 6, 2018 · 4 comments
Open

Add aliases for single color names (ie red) #109

vilmibm opened this issue Jul 6, 2018 · 4 comments

Comments

@vilmibm
Copy link
Owner

vilmibm commented Jul 6, 2018

No description provided.

@modgethanc
Copy link
Contributor

looks like this was fixed in #112, but as an arbitrary personal spelling preference request, i'd also like additional aliases so that 'grey' works in place of everywhere 'gray' is used. so have 'light grey' and 'dark grey' etc.

(this gets me everywhere else that uses standard color names, my fingers just really want to type grey 🙃)

@benjaminwil
Copy link
Collaborator

benjaminwil commented Jul 12, 2018

I will pick up what's left of this issue and write tests!

@benjaminwil
Copy link
Collaborator

I just submitted a pull request, #128, that explicitly adds a grey alias.

However, I think I would like to expand the scope of what can be aliased (not just colors). This is described in more detail in the PR description.

@modgethanc
Copy link
Contributor

@benjaminwil thanks for that PR! i think it makes sense to have a fairly wide scope of what can be aliased; maybe as part of client settings, there should be room for users to define their own aliases.

this probably warrants a new issue, if you'd like to start one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants