Create "grey" color aliases #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwil
changed the title
|
this looks good to me! i just gave it a whirl by manually checking that alias in the client, and it's working. but, you make a good point with aliasing in general; it would be cool to expand on this in the future and have some default and user-editable color and verb aliasing. |
benjaminwil
force-pushed
the
benjaminwil/color_aliases
branch
from
6b481af to
aa55317
Compare
Some users prefer to spell "grey" with the non-American spelling. We should alias the "dark gray" and "light gray" colors to work with their spelling of "grey".
benjaminwil
force-pushed
the
benjaminwil/color_aliases
branch
from
aa55317 to
15ad3f4
Compare
benjaminwil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time doing anything Python.
Some users prefer to spell "grey" with the non-American spelling. We should alias the "dark gray" and "light gray" colors to work with their spelling of "grey".