Remove --unstable flag in default #316
Conversation
WalkthroughThe updates to the Denops project reflect a stabilization of Deno features by removing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 3 3
Lines 85 85
Branches 6 6
=======================================
Hits 82 82
Misses 3 3 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- autoload/denops/server.vim (1 hunks)
- deno.jsonc (1 hunks)
- doc/denops.txt (1 hunks)
Files skipped from review due to trivial changes (1)
- autoload/denops/server.vim
Additional comments: 6
deno.jsonc (4)
- 4-4: The removal of the
--unstableflag from thetesttask aligns with the upcoming Deno 2.0 changes.- 5-5: The removal of the
--unstableflag from thechecktask is consistent with the Deno 2.0 compatibility update.- 6-6: The
--unstableflag has been correctly removed from thecoveragetask.- 6-6: The
upgradetask now uses version0.11.0of themoltmodule. Ensure that this version is compatible with the rest of the codebase and that all necessary testing has been performed to confirm that the upgrade does not introduce any regressions.doc/denops.txt (2)
- 108-108: The
--unstableflag has been removed from the default Deno arguments for starting a server, which is necessary for compatibility with Deno 2.0.- 108-108: The documentation mentions a restart delay setting to avoid issue Bug:
nvim +"autocmd VimEnter * qa!"would be stuck. #136. Verify that the restart delay has been properly set and documented, and that it effectively addresses the issue.Verification successful
The search for mentions of issue #136 in the repository has yielded a section in
doc/denops.txtthat explicitly mentions theg:denops#server#restart_delaysetting with a comment stating "Restart delay in milliseconds to avoid #136." This is followed by a link to the GitHub issue. This documentation confirms that therestart_delaysetting is indeed intended to address issue #136 and is documented as such.Based on this information, the review comment has been verified as the restart delay has been properly set and documented, and it is explicitly stated to effectively address issue #136.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the restart delay setting is documented and verify it against issue #136. rg --type vim 'g:denops#server#restart_delay' -C 5 # Expecting to see the restart delay setting and its explanation in the context of issue #136.Length of output: 773
Script:
#!/bin/bash # Search for documentation or comments regarding 'restart_delay' in the vicinity of its usage. rg --type vim 'restart_delay' -C 10 # Expecting to find explanatory comments or documentation that connects the setting to issue #136.Length of output: 5608
Script:
#!/bin/bash # Search for any mentions of issue #136 in the repository to see if 'restart_delay' is referenced in that context. rg '#136' -C 10 # Expecting to find a connection between 'restart_delay' and the resolution of issue #136.Length of output: 928
Because
--unstableflag will be removed in Deno 2.0 and Deno 1.40 has the warnings.It should not be merged yet. Because if--unstableflag is removed, Deno kv storage cannot be used.Deno KV works in Deno 1.40 without
--unstable.Summary by CodeRabbit
--unstableflag to enhance stability and compatibility.moltmodule to version0.11.0.