-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo #370
Fix typo #370
Conversation
WalkthroughThe change updates a variable assignment within a Vim script function in the Changes
Poem
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 9 9
Lines 676 676
Branches 64 64
=======================================
Hits 610 610
Misses 66 66 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- autoload/denops/_internal/plugin.vim (1 hunks)
Additional comments not posted (1)
autoload/denops/_internal/plugin.vim (1)
57-57
: Ensure consistency in variable usage.The change from
a:name
tol:name
in the assignment ofl:plugin
is aimed to fix a typo and use the local variablel:name
instead of the argument variablea:name
. This is a good practice as it ensures that the function uses the most relevant scope of variable. However, make sure this change is consistently applied across all functions wherel:plugin
is assigned to ensure uniform behavior.#!/bin/bash # Description: Ensure that `l:plugin` is consistently assigned using `l:name` across all functions. # Test: Search for inconsistent usage of `l:plugin` assignment. Expect: No occurrences of `a:name` in such assignments. rg --type vim $'let l:plugin = denops#_internal#plugin#get(a:name)'
Summary by CodeRabbit