Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ssr): add a missing closing parenthesis #15429

Merged
merged 1 commit into from
Dec 26, 2023
Merged

docs(ssr): add a missing closing parenthesis #15429

merged 1 commit into from
Dec 26, 2023

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Dec 26, 2023

Description

This fixes a small error in the code comment in SSR documentation.

resolve #15428

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@shuuji3 shuuji3 mentioned this pull request Dec 26, 2023
Closed
bluwy
bluwy approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In the future, feel free to create the PR directly for simple changes too.

@bluwy bluwy merged commit 56ae92c into vitejs:main Dec 26, 2023
9 checks passed
@shuuji3 shuuji3 deleted the patch-1 branch December 26, 2023 13:40
@shuuji3
Copy link
Contributor Author

shuuji3 commented Dec 26, 2023

I see! Thank you for reviewing 🙂

@shuuji3 shuuji3 mentioned this pull request Dec 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing a closing parenthesis in docs/guide/ssr.md
2 participants
@shuuji3 @bluwy