-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an option to not start a websocket server #16219
Conversation
|
2ddc0d1
to
6672fd5
Compare
@sheremet-va Is this something you'd like to get out soon? I think we can merge this in a patch since it's not a big change, otherwise if it's not urgent we can queue this for the next minor. |
I am fine with it being in a minor. I am using a workaround by assigning a dummy |
Description
This PR adds an option
server.ws
that can only be equal tofalse
. I wasn't sure if I should changeserver.hmr
type (make it nullable like the watcher?), so I added a new one. If we want to useserver.hmr
, we would need to replace allserver.hmr === false
.Also, do we want to document this option?
Closes #14328
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).