fix(ssr): exclude module
condition from ssr node resolve
#16647
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pluginContainer.resolveId(..., { ssr: true })
works differently fromssrLoadModule
resolution for"module"
entry/exports #16631It looks like
vite:resolve
plugin'stryNodeResolve
doesn't setoverrideConditions
and it will end up includingmodule
as conditions and it's impossible to exclude it from user config:vite/packages/vite/src/node/plugins/resolve.ts
Lines 1101 to 1105 in 60824f0
This contracts with ssr module loader's node resolve, which explicitly exclude
module
conditions:vite/packages/vite/src/node/ssr/ssrModuleLoader.ts
Line 141 in 60824f0
todo
'module'
when!targetWeb
would be too breaking?