fix(optimizer): re-optimize when changing config webCompatible
#18221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When flipping
webCompatible: boolean
, it should re-optimize as it affectsimport { createRequire } from 'module'
banner etc..., but it didn't as this flag wasn't included in config hash.additional context
I was setting up module runner in web worker and started with forgetting to enable
webCompatible: true
https://github.com/hi-ogawa/vite-environment-examples/blob/f2d1d071bc47bf1c8e6aabc17f6d631537ddb152/examples/web-worker/vite.config.ts#L17, so optimizer injectingimport { createRequire } from 'module'
banner, which then fails on web worker.Flipping
webCompatible
didn't re-optimize so keep getting errors.Also it's probably a difference issue, but running it with(EDIT: it looks like--force
doesn't seem to trigger re-optimization of custom environments.--force
only affects client, so I had to doenvironments.worker.dev.optimizeDeps.force: true
)