refactor(resolve): remove environmentsOptions parameter
#18590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Nov 6, 2024
Comment on lines
-184
to
-190
| /** | ||
| * @internal | ||
| * config.createResolver creates a pluginContainer before environments are created. | ||
| * The resolve plugin is especial as it works without environments to enable this use case. | ||
| * It only needs access to the resolve options. | ||
| */ | ||
| environmentsOptions?: Record<string, ResolvedEnvironmentOptions>, |
There was a problem hiding this comment.
I checked config.createResolver, but didn't find this to be used. Is this still used?
patak-dev
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Ah, yes, nice! We were able to avoid this hack once we introduced PartialEnvironment. Thanks @sapphi-red!
sapphi-red
added a commit
to rolldown/vite
that referenced
this pull request
Nov 6, 2024
sapphi-red
deleted the
refactor-resolve-remove-environments-option-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description