Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use same pattern in examples #5051

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

akellbl4
Copy link
Contributor

@akellbl4 akellbl4 commented Jan 26, 2024

Description

Mocking guide already shows off example with originalModule inside of vi.mock so use the same pattern for the second example.

  • make code examples with vi.mock consistent
  • add types for imported modules to the examples

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

the guide already shows off example with `originalModule` inside of `vi.mock` so use the same pattern for the second example
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 7bd3591
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65b41395565b550008fe7b58
😎 Deploy Preview https://deploy-preview-5051--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akellbl4 akellbl4 changed the title [docs]; use same pattern in examples [docs] use same pattern in examples Jan 26, 2024
@akellbl4 akellbl4 changed the title [docs] use same pattern in examples docs: use same pattern in examples Jan 26, 2024
@sheremet-va sheremet-va merged commit 2c5d192 into vitest-dev:main Jan 30, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants