-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Make UT cases in test_comm_ops.py compatible with more devices. #14091
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sunshine162 <[email protected]>
Signed-off-by: Sunshine162 <[email protected]>
Signed-off-by: Sunshine162 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: wwfu <[email protected]>
Signed-off-by: wwfu <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
At present, the test cases in
tests/distributed/test_comm_ops.py
only support CUDA but don't support other devices. This PR resolve the problem with the following modification:vllm.platforms.Platform
:communicate_backend
set_device
anddevice_count
vllm.platforms.cuda.CudaPlatformBase
:communicate_backend
set_device
anddevice_count
init_test_distributed_environment
in the codetests/utils.py
, when calling the functioninit_distributed_environment
, specify value to backend parameter based on the platform, instead of using default value.tests/distributed/test_comm_ops.py
,call device settings and device counting in a more general way.