Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enabling torch profiler in openai chat backend #14162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huaqiangwang
Copy link

@huaqiangwang huaqiangwang commented Mar 4, 2025

The 'profile' feature failed in running benchmark_server.py. Reason is the '/start_profile' and '/stop_profile' is prevented by the async_request_openai_chat_completions check.
Just like what async_request_openai_completions function does, make urls ending with 'profile' valid in the request check function.

Copy link

github-actions bot commented Mar 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@huaqiangwang huaqiangwang force-pushed the openai-chat-profile branch from 081c7f7 to 971e020 Compare March 4, 2025 03:02
@huaqiangwang huaqiangwang changed the title Fix: pass '/start_profile' and '/stop_profile' to backend in benchmar… Fix enabling profiler in openai chat backend Mar 4, 2025
@huaqiangwang huaqiangwang force-pushed the openai-chat-profile branch from 971e020 to 28ad871 Compare March 4, 2025 03:04
@huaqiangwang huaqiangwang changed the title Fix enabling profiler in openai chat backend Fix enabling torch profiler in openai chat backend Mar 4, 2025
@huaqiangwang huaqiangwang force-pushed the openai-chat-profile branch from 28ad871 to 6f7ac65 Compare March 4, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant