Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartyPants quote handling isn’t actually compliant with original implementation #53

Closed
codyrobbins opened this issue Sep 5, 2011 · 2 comments

Comments

@codyrobbins
Copy link
Contributor

Here are a few counterexamples which John Gruber’s original Perl implementation of SmartyPants correctly handle:

  • ma'am
  • o'clock
  • s'étendre
  • à l'extrême
  • j'apprecie tes efforts
  • d'une manière soignée
  • c'est pour cela que

Looking at ext/redcarpet/html_smartypants.c, this appears to be due to the hard-coded recognition of a small subset of English contractions in smartypants_cb__squote. Is there a way to handle these single quotes more generally while maintaining the same performance?

@vmg
Copy link
Owner

vmg commented Sep 8, 2011

Ironically, I tend to forget there are languages other than English. Looking into a fix.

@robin850
Copy link
Collaborator

robin850 commented May 8, 2013

Duplicate of #57 and #66.

@robin850 robin850 closed this as completed May 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants