Smarty filter doesn't convert straight single quote into curly single quote

[steverandy]

In the release of b5, the Smarty filter doesn't convert straight single quote into curly single quote.

It was working properly in b4.

[codyrobbins]

I’m seeing the same thing. When using Redcarpet::Render::SmartyPants in a standalone capacity it correctly handles single quotes, replacing them with ’. However, when mixing in a subclass of Redcarpet::Render::HTML it simply replaces them with '. Double quotes, en and em dashes, etc. are all properly replaced, but not single quotes.

The following minimal test case

class TestRenderer < Redcarpet::Render::HTML
  include(Redcarpet::Render::SmartyPants)
end

Redcarpet::Markdown.new(TestRenderer).render(%q(This "works" but this doesn't.))

for me produces

"<p>This &ldquo;works&rdquo; but this doesn&#39;t.</p>\n"

The following

Redcarpet::Render::SmartyPants.render(%q(This "works" but this doesn't.))

however correctly produces

"This “works” but this doesn’t."

I cursorily tried to track down the problem but don’t immediately see where the ' is coming from.

[steverandy]

I use this as a temporary fix.

markdown = Redcarpet::Markdown.new(Redcarpet::Render::HTML)
html = markdown.render content
html.gsub!("'", "'")
html = Redcarpet::Render::SmartyPants.render html

[telemachus]

This doesn't seem to have been fixed for the 2.0.0 release. Or am I mistaken? (I'm curious because I want to update nanoc's Redcarpet support, and I want to make sure that SmartyPants rendering still works.)

[codyrobbins]

Yup, it’s still broken for me in 2.0.0.

[dpk]

This is still an issue. Is there any plan to fix it or is it now Expected Behaviour™?

[puyo]

+1 vote to fix this

[puyo]

My workaround was to completely write my own SmartyPants replacement set of gsubs, which are less smart because they rely on me using backtick characters like LaTeX/Markdown, but I think I prefer it that way, since AFAIK, there isn't actually a way to programmatically predict all the crazy ways English can use curly quotes, and I was having specific problems, like the curly quote being the wrong way around when abbreviating the front of a word, like 'round instead of around.

https://github.com/puyo/poetry.gregorymcintyre.com/blob/master/lib/ensmarten.rb

[aprescott]

+1 to fixing this. @vmg, any news on this / #53 / #66?

The temporary fix above isn't great for me, since there's a custom renderer. @mmorearty seems to have added a possible fix with his referencing commit.

Just to repeat @steverandy:

Redcarpet::Markdown.new(Redcarpet::Render::SmartyHTML).render(%q{This "works" but this doesn't"})
# => "<p>This &ldquo;works&rdquo; but this doesn&#39;t&quot;</p>\n" 
#
# note the &#39;

And yet, using SmartyPants.render does work as expected, which is counterintuitive:

Redcarpet::Render::SmartyPants.render(%q{This "works" but this doesn't"})
# => "This “works” but this doesn’t"" 
#
# note the ’ where ' was above

I'd like to see both behaving the way SmartyPants.render does, since that's the correct output.

[aprescott]

The fix seems to be in #200 as a pull request.