Skip to content

Commit

Permalink
Update prepare-supervisor-on-kind.sh final polish
Browse files Browse the repository at this point in the history
  • Loading branch information
benjaminapetersen authored Apr 11, 2024
1 parent 41f8663 commit a72155a
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions hack/prepare-supervisor-on-kind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,7 @@ EOF
fi

if [[ "$use_github_upstream" == "yes" ]]; then
# Make an GitHubIdentityProvider. Needs to be configured with an actual GitHub App or GitHub OAuth App.
# TODO: claims ought be configured
# Make an GitHubIdentityProvider. Needs to be configured with an actual GitHub App or GitHub OAuth App.
cat <<EOF | kubectl apply --namespace "$PINNIPED_TEST_SUPERVISOR_NAMESPACE" -f -
apiVersion: idp.supervisor.pinniped.dev/v1alpha1
kind: GitHubIdentityProvider
Expand All @@ -318,8 +317,7 @@ spec:
policy: AllGitHubUsers
EOF

# Make a Secret for the above GitHubIdentityProvider to describe the GitHub client configured.
# TODO: make clientID and clientSecret configurable, create & store values in our secret manager
# Make a Secret for the above GitHubIdentityProvider to describe the GitHub client configured.
cat <<EOF | kubectl apply --namespace "$PINNIPED_TEST_SUPERVISOR_NAMESPACE" -f -
apiVersion: v1
kind: Secret
Expand All @@ -332,7 +330,6 @@ stringData:
EOF
fi


# Create a CA and TLS serving certificates for the Supervisor's FederationDomain.
if [[ ! -f "$root_ca_crt_path" ]]; then
step certificate create \
Expand Down Expand Up @@ -469,8 +466,6 @@ if [[ "$use_github_upstream" == "yes" ]]; then
EOF
fi



# Apply the FederationDomain from the file created above.
kubectl apply --namespace "$PINNIPED_TEST_SUPERVISOR_NAMESPACE" -f "$fd_file"

Expand Down

0 comments on commit a72155a

Please sign in to comment.