-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump libs to K8s 1.30 #1921
Bump libs to K8s 1.30 #1921
Conversation
024a4ac
to
f927405
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
==========================================
- Coverage 38.45% 29.45% -9.00%
==========================================
Files 350 350
Lines 44680 58538 +13858
==========================================
+ Hits 17182 17244 +62
- Misses 26983 40779 +13796
Partials 515 515 ☔ View full report in Codecov by Sentry. |
e64c889
to
696d84f
Compare
696d84f
to
80e61eb
Compare
80e61eb
to
7373a78
Compare
I added 1.30 to the verify-codegen CI job and it failed with this error on the 1.30 codegen:
So that's another item on the TODO list for this PR. Reverting the commit (https://github.com/vmware-tanzu/pinniped-ci/commit/a7f342b81ca625d9ad2fea4ca38afb6ada7055e4) for now, but we need to figure out how to bring it back. Update: I think I fixed this in the most recent commits. |
This PR is also failing this integration test in CI about 50% of the time. This needs investigation during this PR effort.
Update: I added a potential fix for this problem to this PR. See below. |
85cf5c7
to
2f8d025
Compare
2f8d025
to
1ac2215
Compare
d5259ec
to
9d21bca
Compare
lgtm as of |
Bump libs to K8s 1.30.