vcsim: add TaskHistoryCollector support #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
force-pushed
the
vcsim-task-history
branch
4 times, most recently
from
0b50b63 to
3eb9981
Compare
dougm
force-pushed
the
vcsim-task-history
branch
3 times, most recently
from
e63976a to
cfe7f17
Compare
akutz
reviewed
Apr 1, 2024
simulator/task_manager.go
Outdated
| @@ -43,29 +46,96 @@ func (m *TaskManager) init(r *Registry) { | |||
| m.Description = esx.Description | |||
| } | |||
| } | |||
|
|
|||
| if m.MaxCollector == 0 { | |||
| m.MaxCollector = 1000 | |||
There was a problem hiding this comment.
We should probably make this a well-documented constant.
There was a problem hiding this comment.
Added a var maxCollectors. Looks like VC's default is 32 and can be changed w/ OptionManager, but don't have a use-case to support that yet.
There was a problem hiding this comment.
Should it be a constant that we can adjust as needed? Is there any reason it should be a variable?
There was a problem hiding this comment.
If we end up with a use-case to support changing the max via OptionManager, then we'd need a variable. But I just clumped it into the existing set of non-exported var (...), do we gain anything by making it a constant?
TaskHistoryCollector provides a way to collect Task history beyond the 10 minute max of the 'RecentTask' property. And unlike 'RecentTask', can filter based on Task state and collect tasks of child entities. refactor portions of 'EventHistoryCollector' to 'HistoryCollector' for use with 'TaskHistoryCollector' govc: add history flags to 'tasks' command Closes vmware#2567
dougm
force-pushed
the
vcsim-task-history
branch
from
cfe7f17 to
4cec059
Compare
|
Thanks @akutz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor portions of 'EventHistoryCollector' to 'HistoryCollector' for use with 'TaskHistoryCollector'
TaskHistoryCollector provides a way to collect Task history beyond the 10 minute max of the 'RecentTask' property.
And unlike 'RecentTask', can filter based on Task state and collect tasks of child entities.
govc: add history flags to 'tasks' command
Closes #2567