Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvement for OpenJDK 17/21 #1593

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

dcasota
Copy link
Contributor

@dcasota dcasota commented Feb 9, 2025

See #1588

@@ -107,6 +108,18 @@ sh ./configur* \
--with-freetype-lib=%{_libdir} \
--with-stdc++lib=dynamic \
--disable-warnings-as-errors
%else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this will suffice for both aarch64 and x86_64 without code duplication and condition checking.

sh ./configur* \
    --with-target-bits=64 \
    --enable-headless-only \
    --with-extra-cxxflags="-Wno-error -fno-delete-null-pointer-checks -fno-lifetime-dse" \
    --with-extra-cflags="-fno-delete-null-pointer-checks -Wno-error -fno-lifetime-dse" \
    --with-freetype-include=%{_includedir}/freetype2 \
    --with-freetype-lib=%{_libdir} \
    --with-stdc++lib=dynamic \
    --build=%{_build} \
    --disable-warnings-as-errors

Reference: https://github.com/rpm-software-management/rpm/blob/master/macros.in#L1066

Please give this a try. Thanks for your contribution and continues engagement to make our product better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Photon OS on any non-VMware hypervisor is often not recognized. That's a main challenge.
Previously, #1542 was the intention so get solved.
E.g. for cloud-init, dark2phoenix took the extra mile in canonical/cloud-init#5077. That was a year ago, and the time to get it done wasn't little.
A code snippet for on aarch64 and x86_64 without code duplication and condition checking is best, no doubt.

I have to test a few things first and will come back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants