Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control plane overrides for VKS 3.2 #488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hxietkg
Copy link
Contributor

@hxietkg hxietkg commented Jan 7, 2025

Summary

To support overrides variables in control plane, which is a new feature for VKS 3.2.0

Type

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

image
image

@github-actions github-actions bot added documentation Documentation provider Provider needs-review Needs Review labels Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 19.95%. Comparing base (3578fd2) to head (3b120ec).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/resources/tanzukubernetescluster/helper.go 0.00% 23 Missing ⚠️
...anzukubernetescluster/tests/resource_tf_configs.go 0.00% 3 Missing ⚠️
...netescluster/resource_tanzu_kuberenetes_cluster.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3578fd2) and HEAD (3b120ec). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3578fd2) HEAD (3b120ec)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   25.23%   19.95%   -5.29%     
==========================================
  Files         195      264      +69     
  Lines       16908    23648    +6740     
==========================================
+ Hits         4267     4719     +452     
- Misses      12423    18715    +6292     
+ Partials      218      214       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hxietkg hxietkg force-pushed the vmware/hxie/cp-overrides branch from a79aad9 to 7988d15 Compare January 8, 2025 02:00
@hxietkg hxietkg force-pushed the vmware/hxie/cp-overrides branch from 7988d15 to 3b120ec Compare January 8, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation needs-review Needs Review provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants