-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update naming style from imperative to declarative #491
base: main
Are you sure you want to change the base?
Conversation
@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
d216f4a
to
2cff4ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 25.23% 19.96% -5.27%
==========================================
Files 195 264 +69
Lines 16908 23632 +6724
==========================================
+ Hits 4267 4719 +452
- Misses 12423 18699 +6276
+ Partials 218 214 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vivgoyal giving this a bump for a review. |
Signed-off-by: Steve Wall <[email protected]>
2cff4ef
to
f4738bf
Compare
@vivgoyal Sorry to bother you with this, but if you could give this a review that would great! |
Giving a bump for visibility. @vivgoyal would a bottle of scotch help? Maybe bourbon? Some good wine? I'll do whatever it takes. ;-) |
Hi @stevewallone 👋🏻 - Vivek is out of office currently, but I've shared a reminder internally for return. |
Summary
The terraform files use an imperative style, i.e. create_tkg_cluster. The convention is to use a declarative style that doesn't imply an actions, i.e. tkg_cluster.
Type
Please describe:
Breaking Changes?
Test and Documentation
Issue References
Resolves #482
Additional Information