Added check to store vxlan_subnet information in terraform state file only when skip_creating_vxlan = false #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shylasrinivas
approved these changes
Dec 15, 2020
rchadalawada
approved these changes
Dec 15, 2020
|
The vxlan_subnet value is stored in the state file only when skip_creating_vxlan = false. Otherwise this field is not stored in the state file |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GET / POST SDDC API populates the vxlan_subnet with the default value when skip_creating_vxlan = true without actually creating a network segment. Since this field is not provided in the configuration file while provisioning the SDDC, when a user does terraform apply the vxlan_subnet field (with ForceNew : true in schema) forces the SDDC resource to be destroyed and new one to be created. As a workaround for now, we are storing the vxlan_subnet only when skip_creating_vxlan = false since that is when the network segment is created.