Change how ruby proxy is invoked.

[nanliu]

No description provided.

[TeunRoefs]

@nanliu Almost there, changing Net::HTTP.start(uri.host, uri.port, http_opts, @proxy_addr, @proxy_port) to Net::HTTP.start(uri.host, uri.port, @proxy_addr, @proxy_port, http_opts) will fix the issue on Windows.

See: https://docs.ruby-lang.org/en/2.0.0/Net/HTTP.html#method-c-start

[TeunRoefs]

@nanliu Ready for merge I guess? Is there anything I need to do?

[TeunRoefs]

Any update on this PR, kinda need this functionality and do not want to fork the module.

[alexjfisher]

LGTM

alex@phantom:~$ cat test.pp
archive { '/tmp/afisher.test':
  ensure       => present,
  source       => 'https://github.com/voxpupuli/puppet-archive/archive/master.zip',
  cleanup      => false,
  extract      => false,
  proxy_server => 'http://localhost:3128',
  provider     => 'ruby',
}

alex@phantom:~$ sudo tail /var/log/squid/access.log
alex@phantom:~$ rm /tmp/afisher.test ;puppet apply -t test.pp; sudo tail /var/log/squid/access.log
Info: Loading facts
Info: Loading facts
Notice: Compiled catalog for phantom in environment production in 0.13 seconds
Info: Applying configuration version '1495047363'
Notice: /Stage[main]/Main/Archive[/tmp/afisher.test]/ensure: download archive from https://github.com/voxpupuli/puppet-archive/archive/master.zip to /tmp/afisher.test  without cleanup
Notice: Applied catalog in 1.22 seconds
1495047364.754    749 127.0.0.1 TCP_TUNNEL/200 232053 CONNECT codeload.github.com:443 - HIER_DIRECT/192.30.253.120 -
1495047364.754   1161 127.0.0.1 TCP_TUNNEL/200 6126 CONNECT github.com:443 - HIER_DIRECT/192.30.253.113 -

[alexjfisher]

This line should never be hit?

I still think we've got confusion about what proxy_type is supposed to do. Is it the scheme of the URL needing proxying, or the scheme of the proxy server URL? At the moment, the parameters behave differently depending on the provider.
According to the README and original proxy PR, proxy_server is supposed to be of the form http://my_proxy.example.com:3128 ? I think it's confusing to try and support multiple forms considering the already differing behaviour between providers.

[KZachariassen]

Could we get this merged and created a new release? - need this functionality

[edestecd]

I can confirm this works as well on windows...