fixup! Replace Exec with File resource

voxpupuli · Oct 7, 2018 · 9a4d0d0 · 9a4d0d0
1 parent 7173620
commit 9a4d0d0
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/spec/classes/snmp_init_spec.rb b/spec/classes/snmp_init_spec.rb
@@ -488,10 +488,12 @@
         end
         it { is_expected.not_to contain_file('snmptrapd.sysconfig') }
         it {
-          is_expected.to contain_exec('install /etc/init.d/snmptrapd').with(
-            command: '/usr/bin/install -o 0 -g 0 -m0755 -p /usr/share/doc/packages/net-snmp/rc.snmptrapd /etc/init.d/snmptrapd',
-            creates: '/etc/init.d/snmptrapd'
-          ).that_requires('Package[snmpd]')
+          is_expected.to contain_file('/etc/init.d/snmptrapd').with(
+            source: '/usr/share/doc/packages/net-snmp/rc.snmptrapd',
+            owner:  'root',
+            group:  'root',
+            mode:   '0755'
+          ).that_requires('Package[snmpd]').that_comes_before('Service[snmptrapd]')
         }
         it {
           is_expected.to contain_service('snmptrapd').with(
@@ -500,7 +502,7 @@
             enable: false,
             hasstatus: true,
             hasrestart: true
-          ).that_requires(['Package[snmpd]', 'File[var-net-snmp]', 'Exec[install /etc/init.d/snmptrapd]'])
+          ).that_requires(['Package[snmpd]', 'File[var-net-snmp]', 'File[/etc/init.d/snmptrapd]'])
         }
       end
     end