ensure => absent fails on el5/el6 if net-snmp-utils is installed

[jhoblitt]

This module is able to install net-snmp-utils on el{56}.x by setting install_client => true but won't uninstall via ensure => absent unless install_client => true is also set. Eg.

Execution of '/bin/rpm -e net-snmp-5.3.2.2-17.el5_8.1.x86_64' returned 1: error: Failed dependencies: net-snmp = 1:5.3.2.2-17.el5_8.1 is needed by (installed) net-snmp-utils-5.3.2.2-17.el5_8.1.x86_64

This is a minor nitpick but I find the parameter misleading. Perhaps manage_client would be more intutive? Or would it make sense for ensure => absent to explicity set the same on snmp::client?

[razorsedge]

I will have to dig into this. I might lean toward ensure => absent propagating to snmp::client.

I am not happy that package { 'foo': ensure => present } runs yum while package { 'foo': ensure => absent } runs rpm.

[jhoblitt]

The logic behind that is that yum will try to remove everything that
depends that package where as rpm removes just the package. Yum's
behavior is better in this instance but is known to cause breakage by
being over zealous. Eg., uninstalling all of gnome because you want to
remove cups.

I think there may be a way to force it to use yum for the removal but
it's been awhile since I've looked at the code for that type.

[razorsedge]

@jhoblitt How does aa6755a look?

[jhoblitt]

👍 This looks great / much less confusing.

[razorsedge]

@jhoblitt You wouldn't happen to know how to test the Puppet warning function in rspec would you?

This just does not work in rspec-puppet:

it { should contain_warning('snmp: parameter install_client is deprecated; please use manage_client')}

[jhoblitt]

Unfortunately, you can't test if a function call happened that way because the contain_* methods inspect the state of the generated catalog (which only contains resources). The only solution I've come up with for warnings is to look for the string in the stderr with rspec-system/beaker. Eg: https://github.com/puppetlabs/puppetlabs-concat/blob/master/spec/acceptance/deprecation_warnings_spec.rb

[razorsedge]

Ah, yes. That makes sense now. I keep getting client catalog confused with server-side stuff.

[razorsedge]

This ships in Forge release 3.2.0.

[jhoblitt]

Fabulous!