Implemented sRGB support in ShaderSets and default format for colour framebuffer #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already telling the implementation to interpret it as if it were sRGB via VK_COLOR_SPACE_SRGB_NONLINEAR_KHR, but with the image format as UNORM rather than SRGB, we'd have to explicitly convert before emitting the colour from the shader, even though that makes blending wrong.
They were backwards.
… linearRGB and sRGB. Updated built-in ShaderSets.
…e able to rely upon sRGB format setting where appropriate in vsgXchange
…g the CoordianteSpace to ShaderSets.
…xture(const std::string& name, const ImageInfoList& imageInfoList, uint32_t dstArrayElement)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.