Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License is missing #441

Closed
AtishaGarinMchd opened this issue Mar 4, 2021 · 3 comments · Fixed by #443
Closed

License is missing #441

AtishaGarinMchd opened this issue Mar 4, 2021 · 3 comments · Fixed by #443
Labels
Task

Comments

@AtishaGarinMchd
Copy link 

$ yarn pack @vuejs/vue-test-utils-next
yarn pack v1.22.5
warning package.json: No license field
@LinusBorg
Copy link
Member

https://github.com/vuejs/vue-test-utils-next/blob/9e8d0b2da1c4141ddb0887933e598dd52c046929/package.json#L4

???

@AtishaGarinMchd
Copy link
Author

Indeed the field is provided - implemented npm check and its warn message is wrong (similar issue here).
For reasons my legal department prefers having a proper license file.
Having a license such as v1.0 is preferrable https://github.com/vuejs/vue-test-utils/blob/dev/LICENSE.
I suppose it will populate Github Code page right hand side 'About' field too.

@LinusBorg
Copy link
Member

That's a valid point, this is an oversight on our part and we'll add it.

Thanks!

@LinusBorg LinusBorg mentioned this issue Mar 5, 2021
Merged
LinusBorg pushed a commit that referenced this issue Mar 5, 2021
chore: add LICENSE file
be7e0a6 
close #441
@LinusBorg LinusBorg added the Task label Mar 5, 2021
lmiller1990 pushed a commit that referenced this issue Mar 6, 2021
@LinusBorg
chore: add LICENSE file (fix #441) (#443)
679c164 
close #441

Co-authored-by: Thorsten Luenborg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add LICENSE file (fix #441) vuejs/test-utils
2 participants
@LinusBorg @AtishaGarinMchd