New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: site base get / #1504

Closed

afeiship wants to merge 1 commit into vuejs:master from afeiship:master

afeiship commented Apr 1, 2019

See: #1503


          fix: site base get /

53b0f29

Collaborator

shigma commented Apr 2, 2019

Thanks for the PR. However, it is not a good approach for me.

const routerBase = typeof window !== 'undefined'
  ? window.__VUEPRESS_ROUTER_BASE__
  : undefined

const router = new Router({
  base: routerBase || siteData.routerBase || siteData.base

ulivz closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet