exclude nested forms from validation

[neelance]

If a v-form contains a v-dialog which in turn contains another v-form, then it breaks the validation of the outer form, since inputs of the inner form affect the outer one.

Is this an acceptable solution to the issue?

[codecov]

Codecov Report

Merging #2632 into master will decrease coverage by 0.04%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2632      +/-   ##
==========================================
- Coverage   68.19%   68.14%   -0.05%     
==========================================
  Files         118      118              
  Lines        3147     3149       +2     
  Branches      996      997       +1     
==========================================
  Hits         2146     2146              
- Misses        716      718       +2     
  Partials      285      285

Impacted Files	Coverage Δ
src/components/VForm/VForm.js	38.09% <50%> (+0.59%)	⬆️
src/components/VTimePicker/mixins/time-title.js	69.23% <0%> (-7.7%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6f448...8beaed3. Read the comment docs.

[johnleider]

Please do not push with --no-verify.

[neelance]

I did not use any --no-verify.

[johnleider]

The test is re-running, but it had previously failed with lint errors, you shouldn't be able to commit or push with test/lint errors without --no-verify.

[neelance]

I used the GitHub web UI for this small change. Did a full checkout now since I saw the linter errors.

[neelance]

CI is happy now, but codecov isn't. Unfortunately I don't have the time to get to know your testing setup and a test case with a nested v-form and triggering validation seems non-trivial. What's your policy on this?

[KaelWD]

You can ignore that, it's thinking there's changes in VTimePicker for some reason.

[neelance]

Okay, thanks. So is this a good solution and ready to merge?

[nekosaur]

It's a solution for now. Forms will most likely be refactored to use inject/provide for 1.1. Although I am actually not sure how to solve this problem when we do..

edit: nevermind, it should be automatically solved by using inject/provide

[johnleider]

Forms are currently being refactored to use provide/inject for 1.1. Was already mentioned here #2033. Thank you for your contribution.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord